Skip to content

Bump openblas, suitesparse, mpfr #13808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2015
Merged

Bump openblas, suitesparse, mpfr #13808

merged 2 commits into from
Oct 29, 2015

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Oct 28, 2015

bumping openblas fixes JuliaLang/LinearAlgebra.jl#245 so should be backported if it doesn't cause any issues. MPFR and suitesparse don't fix anything specific as far as I can tell so we can leave them alone on release-0.4, but may as well use latest on master.

@tkelman
Copy link
Contributor Author

tkelman commented Oct 29, 2015

Can someone on a mac test this branch after a make -C deps distclean-openblas distclean-suitesparse distclean-arpack distclean-mpfr ?

@ViralBShah
Copy link
Member

Suitesparse for sure doesn't have any relevant bugfixes for us. I did review the changelog a few days back.

@tkelman
Copy link
Contributor Author

tkelman commented Oct 29, 2015

If it started being threadsafe or supporting shared libraries without hacks I'd think more than the patch number would change and we'd notice. Still, shouldn't hurt to upgrade.

@ViralBShah
Copy link
Member

Yes - I just meant not worth backporting suitesparse, although that would be fine too if we want to.

@quinnj
Copy link
Member

quinnj commented Oct 29, 2015

Everything built fine over here, running tests now:

julia> versioninfo()
Julia Version 0.5.0-dev+1007
Commit bd040da* (2015-10-28 18:23 UTC)
Platform Info:
  System: Darwin (x86_64-apple-darwin15.0.0)
  CPU: Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.3

@quinnj
Copy link
Member

quinnj commented Oct 29, 2015

....and all tests pass.

@tkelman
Copy link
Contributor Author

tkelman commented Oct 29, 2015

Thanks @quinnj. That and the platforms I tested on say let's merge this and see if anyone with unusual processor types notices anything.

tkelman added a commit that referenced this pull request Oct 29, 2015
Bump openblas, suitesparse, mpfr
@tkelman tkelman merged commit 41c7b64 into master Oct 29, 2015
@tkelman tkelman deleted the tk/bumpdeps branch October 29, 2015 07:19
tkelman added a commit that referenced this pull request Oct 31, 2015
(cherry picked from commit bd040da)
ref #13808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cholesky test fails due to rank deficiency with make testall1
3 participants