-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Minor cleanup on BitArray constructors to fully allow for Integer types #16582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
base/bitarray.jl
Outdated
end | ||
nc = num_bit_chunks(n) | ||
chunks = Array{UInt64}(nc) | ||
chunks = Array(UInt64, nc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong conflict resolution with #16498
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I must have started editing this before pulling from master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appveyor's getting confused about mergability again...
You could use |
LGTM. As far as I can tell from comparing the outputs of |
Thanks for taking a look @carlobaldassi. |
Should probably be backported, too. |
Standard caveat that if you rely on this working, be careful about patch version in REQUIRE when a release with the backport is available. |
This came up from the following behavior on my 64-bit system:
CC: @carlobaldassi