Skip to content

use a counter for passed tests instead of storing the Result object #20150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2017
Merged

use a counter for passed tests instead of storing the Result object #20150

merged 2 commits into from
Jan 20, 2017

Conversation

KristofferC
Copy link
Member

Should fix #20137. cc @Keno

@tkelman tkelman added the testsystem The unit testing framework and Test stdlib label Jan 20, 2017
tkelman
tkelman reviewed Jan 20, 2017
View reviewed changes
base/test.jl Outdated

# For a passing or broken result, simply store the result
record(ts::DefaultTestSet, t::Union{Pass,Broken}) = (push!(ts.results, t); t)
# For a a broken result, simply store the result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a broken

@KristofferC
Copy link
Member Author

KristofferC commented Jan 20, 2017 •
edited
Loading

Travis before latest ci skipped commit at: https://travis-ci.org/JuliaLang/julia/builds/193693108

@tkelman
Copy link
Contributor

tkelman commented Jan 20, 2017

segfault in valid_type_param in the umfpack test, hm

@KristofferC
Copy link
Member Author

how can I build 32 bit to test the actual issue and see it is fixed?

@tkelman
Copy link
Contributor

tkelman commented Jan 20, 2017

either a vm or there's a docker container i can dig up the link for, or multilib compilers depending on your distro - put these in Make.user and build either in a separate build dir or clean clone.

override ARCH = i686
override MARCH = pentium4

@tkelman
Copy link
Contributor

tkelman commented Jan 20, 2017

couple weeks old, but here's a docker container with a 32 bit build and all deps already compiled (warning: big download): docker run -it tkelman/julia32-part1:manual

@Keno
Copy link
Member

Keno commented Jan 20, 2017

I can just test this locally. Hold on.

@Keno
Copy link
Member

Keno commented Jan 20, 2017

Fixes the issue! Great work, thanks!

@Keno Keno merged commit b7c850e into master Jan 20, 2017
@Keno Keno deleted the kc/test_count branch January 20, 2017 22:48
@KristofferC KristofferC mentioned this pull request Jan 23, 2017
Merged
maleadt pushed a commit that referenced this pull request Feb 24, 2017
@KristofferC @maleadt
use a counter for passed tests instead of storing the Result object (#…
fbff504 
…20150)

ref #20150
(cherry picked from commit b7c850e)
@maleadt maleadt mentioned this pull request Feb 24, 2017
Merged
@KristofferC KristofferC mentioned this pull request Jan 10, 2018
Closed
@mmiller-max mmiller-max mentioned this pull request Aug 2, 2020
Merged
@KristofferC KristofferC mentioned this pull request Mar 10, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kshyatt kshyatt kshyatt approved these changes

+1 more reviewer

@tkelman tkelman tkelman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testsystem The unit testing framework and Test stdlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In testset, use a counter for successes, rather than keeping an array of objects

4 participants

@KristofferC @tkelman @Keno @kshyatt