-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Restoring get_num_threads function of BLAS #21105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note this: julia/test/distributed_exec.jl Lines 1172 to 1191 in e05a921
|
Wrapping in a try to catch unsupported blas versions
IIRC the issue with this in openblas is that it returns the build time hard coded max number of threads, which is much less useful or expected than the run time dynamic number of threads setting. |
@tkelman , because in some case it returns the hard coded max number of threads, it have been deleted, is this right? Can I know anther option to replace this function? |
It would probably be more useful to look at the same environment variables that blas implentations do |
Has this not been fixed by OpenMathLib/OpenBLAS#762? At least here (0.6 and 0.7, linux openblas) it seems to work as expected. This PR should be re-opened as it seems like a useful functionality to have (if only for symmetry wrt set_num_threads) |
I am also in favour of reopening this. I think the MKL call needs to be One important use case I see, as multithreading in Julia is now more easy to use with |
BLAS.get_num_threads function have been deleted by this commit 1da2c9b.
But, I can not find why, I think, I and other people also need this function by #15008.
And It already implemented by @tkelman before.