RFC: hide some of the logging macro expansion inside a function #25911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
commented
Feb 6, 2018
| end | ||
|
|
||
| # This is in a separate function for performance | ||
| function maybe_log(std_level, level, _module, id, group, msg, file, line, kwargs...) |
|
Should benchmark properly if this increases performance or just fixes the closure problem in #25909. The keyword arguments might make it not be that good. |
|
I dont think this works because the point is to delay the creation of the message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25909 cc @maleadt @c42f
code_warntypefrom #25909 at https://gist.github.com/KristofferC/a505c626dbbd687d7e74fbd8ed7f27a1