Skip to content

fix erroneous code path within show_sym #38830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2020
Merged

fix erroneous code path within show_sym #38830

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb95c24
fix erroneous code path within `show_sym`
aviatesk Dec 11, 2020
f13c310
explicit argument type for `show_sym`
aviatesk Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions base/show.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,12 +1445,12 @@ end
# Print `sym` as it would appear as an identifier name in code
# * Print valid identifiers & operators literally; also macros names if allow_macroname=true
# * Escape invalid identifiers with var"" syntax
function show_sym(io::IO, sym; allow_macroname=false)
function show_sym(io::IO, sym::Symbol; allow_macroname=false)
if is_valid_identifier(sym)
print(io, sym)
elseif allow_macroname && (sym_str = string(sym); startswith(sym_str, '@'))
print(io, '@')
show_sym(io, sym_str[2:end])
show_sym(io, Symbol(sym_str[2:end]))
else
print(io, "var", repr(string(sym)))
end
Expand Down