Fix performance regression in broadcasting with CartesianIndices #39333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the boundary check due to a change in the implementation of iteration using `CartecianIndices` in PR JuliaLang#37829. This is a workaround on the caller side and does not change the iteration mechanism itself.
|
Have I been disrespectful to buildbot in any way? |
|
Sometimes you have to wait a bit for the builds to start. |
mbauman
added
backport 1.6
mbauman
approved these changes
Jan 20, 2021
thofma
reviewed
Jan 20, 2021
Co-authored-by: thofma <[email protected]>
KristofferC
pushed a commit
that referenced
this pull request
Jan 21, 2021
) * Fix performance regression in broadcasting with CartesianIndices This avoids the boundary check due to a change in the implementation of iteration using `CartecianIndices` in PR #37829. This is a workaround on the caller side and does not change the iteration mechanism itself. Co-authored-by: Matt Bauman <[email protected]> Co-authored-by: thofma <[email protected]> (cherry picked from commit a4cd68c)
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
) * Fix performance regression in broadcasting with CartesianIndices This avoids the boundary check due to a change in the implementation of iteration using `CartecianIndices` in PR #37829. This is a workaround on the caller side and does not change the iteration mechanism itself. Co-authored-by: Matt Bauman <[email protected]> Co-authored-by: thofma <[email protected]> (cherry picked from commit a4cd68c)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…iaLang#39333) * Fix performance regression in broadcasting with CartesianIndices This avoids the boundary check due to a change in the implementation of iteration using `CartecianIndices` in PR JuliaLang#37829. This is a workaround on the caller side and does not change the iteration mechanism itself. Co-authored-by: Matt Bauman <[email protected]> Co-authored-by: thofma <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…iaLang#39333) * Fix performance regression in broadcasting with CartesianIndices This avoids the boundary check due to a change in the implementation of iteration using `CartecianIndices` in PR JuliaLang#37829. This is a workaround on the caller side and does not change the iteration mechanism itself. Co-authored-by: Matt Bauman <[email protected]> Co-authored-by: thofma <[email protected]>
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
) * Fix performance regression in broadcasting with CartesianIndices This avoids the boundary check due to a change in the implementation of iteration using `CartecianIndices` in PR #37829. This is a workaround on the caller side and does not change the iteration mechanism itself. Co-authored-by: Matt Bauman <[email protected]> Co-authored-by: thofma <[email protected]> (cherry picked from commit a4cd68c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the boundary check due to a change in the implementation of iteration using
CartesianIndicesin PR #37829.This is a workaround on the caller side and does not change the iteration mechanism itself.
Thanks to @chriselrod.
Fixes #38086