Skip to content

inference: SCC handling missing for return_type_tfunc #39375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

inference: SCC handling missing for return_type_tfunc #39375

merged 1 commit into from
Jan 25, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jan 23, 2021

This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361

@vtjnash
inference: SCC handling missing for return_type_tfunc
bad9527 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361
Sacha0
Sacha0 reviewed Jan 23, 2021
View reviewed changes
Sacha0
Sacha0 approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jameson! :)

@Sacha0 Sacha0 added the backport 1.6 Change should be backported to release-1.6 label Jan 23, 2021
@vtjnash vtjnash closed this Jan 25, 2021
@vtjnash vtjnash reopened this Jan 25, 2021
@vtjnash vtjnash merged commit fd8f97e into master Jan 25, 2021
@vtjnash vtjnash deleted the jn/39361 branch January 25, 2021 16:55
KristofferC pushed a commit that referenced this pull request Jan 26, 2021
@vtjnash @KristofferC
inference: SCC handling missing for return_type_tfunc (#39375)
e8e1765 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361

(cherry picked from commit fd8f97e)
@KristofferC KristofferC mentioned this pull request Jan 26, 2021
Merged
60 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Feb 1, 2021
KristofferC pushed a commit that referenced this pull request Feb 1, 2021
@vtjnash @KristofferC
inference: SCC handling missing for return_type_tfunc (#39375)
baf8414 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361

(cherry picked from commit fd8f97e)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@vtjnash @ElOceanografo
inference: SCC handling missing for return_type_tfunc (JuliaLang#39375)
44662d5 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes JuliaLang#39361
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@vtjnash @antoine-levitt
inference: SCC handling missing for return_type_tfunc (JuliaLang#39375)
adfd590 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes JuliaLang#39361
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vtjnash @staticfloat
inference: SCC handling missing for return_type_tfunc (#39375)
d01dec7 
This has actually been broken for a long time, so it only got noticed
when it caused a regression.

Fixes #39361

(cherry picked from commit fd8f97e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Sacha0 Sacha0 Sacha0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression (change) in inference after SCC PR
3 participants
@vtjnash @Sacha0 @KristofferC