Skip to content

Allow edit to select method based on index; print available methods in edit error message #39479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Allow edit to select method based on index; print available methods in edit error message #39479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e66d45
Print available methods in functionloc error
MilesCranmer Feb 1, 2021
db2759a
Allow indexing of methods in `edit`
MilesCranmer Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/methodshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ function functionloc(@nospecialize(f))
end
end
if length(mt) > 1
error("function has multiple methods; please specify a type signature")
error("function has multiple methods; please specify a type signature:\n" * string(mt))
end
return functionloc(first(mt))
end
Expand Down
8 changes: 5 additions & 3 deletions stdlib/InteractiveUtils/src/editless.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,12 @@ end

"""
edit(function, [types])
edit(function, [index])
edit(module)

Edit the definition of a function, optionally specifying a tuple of types to indicate which
method to edit. For modules, open the main source file. The module needs to be loaded with
`using` or `import` first.
Edit the definition of a function, optionally specifying a tuple of types, or method
index, to indicate which method to edit. For modules, open the main source file.
The module needs to be loaded with `using` or `import` first.

!!! compat "Julia 1.1"
`edit` on modules requires at least Julia 1.1.
Expand All @@ -222,6 +223,7 @@ To ensure that the file can be opened at the given line, you may need to call
"""
edit(f) = edit(functionloc(f)...)
edit(f, @nospecialize t) = edit(functionloc(f,t)...)
edit(f::Function, index::Integer) = edit(methods(f).ms[index])
edit(file, line::Integer) = error("could not find source file for function")
edit(m::Module) = edit(pathof(m))

Expand Down