Skip to content

Conversation

josePereiro
Copy link
Contributor

Hi, I just include the show_error_hints part from #39089
Further relevant discussion in discourse

@simeonschaub
Copy link
Member

You need to copy over the changes to base/Base.jl as well to not fail bootstrap.

@simeonschaub simeonschaub added the error messages Better, more actionable error messages label Feb 27, 2021
@simeonschaub simeonschaub added the merge me PR is reviewed. Merge when all tests are passing label Apr 3, 2021
@simeonschaub
Copy link
Member

Sorry I did not get back to this! Feel free to regularly bump PRs in the future, so they don't get forgotten.

@simeonschaub simeonschaub merged commit 28e63dc into JuliaLang:master Apr 3, 2021
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label Apr 3, 2021
@vtjnash
Copy link
Member

vtjnash commented Apr 3, 2021

@simeonschaub when you merge PRs, please confirm the commit message is correct. It looks like you added co-authored-by and other noise which aren't useful.

ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
* add show_error_hints for UndefVarError

Hi, I just include the show_error_hints part from JuliaLang#39089
Further relevant discussion in [discourse](https://discourse.julialang.org/t/help-with-register-error-hint/56140/4)

* Update errorshow.jl

* Update Base.jl

Co-authored-by: Simeon Schaub <[email protected]>
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
* add show_error_hints for UndefVarError

Hi, I just include the show_error_hints part from JuliaLang#39089
Further relevant discussion in [discourse](https://discourse.julialang.org/t/help-with-register-error-hint/56140/4)

* Update errorshow.jl

* Update Base.jl

Co-authored-by: Simeon Schaub <[email protected]>
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
* add show_error_hints for UndefVarError

Hi, I just include the show_error_hints part from JuliaLang#39089
Further relevant discussion in [discourse](https://discourse.julialang.org/t/help-with-register-error-hint/56140/4)

* Update errorshow.jl

* Update Base.jl

Co-authored-by: Simeon Schaub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

error messages Better, more actionable error messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants