Set up a few code owners #40925
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,7 @@ | ||
| /.github/ @JuliaLang/github-actions | ||
| /.buildkite/ @JuliaLang/github-actions | ||
| /src/ @JuliaLang/compiler | ||
| /stdlib/LinearAlgebra/ @JuliaLang/linearalgebra | ||
| /stdlib/libblastrampoline_jll/ @staticfloat | ||
| /test/ @JuliaLang/test | ||
|
There was a problem hiding this comment. I am not sure this is all that useful since almost any PR adds some tests. There was a problem hiding this comment. My thought was to see how useful this feature is and get it calibrated. |
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should be a bit more fine-grained? I'd be comfortable reviewing frontend changes, but likely won't be able to contribute much if it touches codegen or parts of the C API. Also should perhaps add
base/compiler?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of my suggestion in #40925 (comment)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe. Although especially for some files in
basethis might be a bit of a noisy measure and it might be better for folks to be able to opt in manually.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't people's global preferences on notifications anyways override this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant noisy here mostly in terms of that it might be rather arbitrary who is assigned to a file or not, but perhaps that's something we should just try and then see how it goes.