Skip to content

Fix in(x, ::AbstractRange) for NaN/Inf #41169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2021
Merged

Fix in(x, ::AbstractRange) for NaN/Inf #41169

merged 1 commit into from
Jun 14, 2021

Conversation

sostock
Copy link
Contributor

@sostock sostock commented Jun 10, 2021

Fixes #26689.

Before:

julia> Inf in 1.0:5.0
ERROR: InexactError: trunc(Int64, Inf)
[...]

julia> NaN in 1.0:5.0
ERROR: InexactError: trunc(Int64, NaN)
[...]

After:

julia> Inf in 1.0:5.0
false

julia> NaN in 1.0:5.0
false

@oscardssmith
Copy link
Member

oscardssmith commented Jun 10, 2021 •
edited
Loading

Is this fixing a regression?

@sostock
Copy link
Contributor Author

sostock commented Jun 10, 2021

It’s not a regression, the bug exists since version 0.7 or earlier.

@JeffBezanson JeffBezanson added backport 1.6 Change should be backported to release-1.6 backport 1.7 bugfix This change fixes an existing bug labels Jun 14, 2021
@JeffBezanson JeffBezanson merged commit 9a9e5a3 into JuliaLang:master Jun 14, 2021
KristofferC pushed a commit that referenced this pull request Jun 17, 2021
@sostock @KristofferC
Correct _in_range for NaN/Inf (#41169)
0f8223f 
(cherry picked from commit 9a9e5a3)
@KristofferC KristofferC mentioned this pull request Jun 17, 2021
Merged
20 tasks
KristofferC pushed a commit that referenced this pull request Jun 29, 2021
@sostock @KristofferC
Correct _in_range for NaN/Inf (#41169)
9f6aabb 
(cherry picked from commit 9a9e5a3)
@KristofferC KristofferC mentioned this pull request Jun 29, 2021
Merged
45 tasks
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@sostock @johanmon
Correct _in_range for NaN/Inf (JuliaLang#41169)
7a9e57b
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@sostock @staticfloat
Correct _in_range for NaN/Inf (#41169)
85339d2 
(cherry picked from commit 9a9e5a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InexactError() when checking if Float StepRange contains NaNs
4 participants
@sostock @oscardssmith @JeffBezanson @KristofferC