hvncat: Stronger argument checks
#41196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
added
arrays
simeonschaub
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Would be nice to have a full fix for #41047 of course, but this seems like a reasonable fix for now.
|
The one failing tester is unrelated. I recommend extra care be taken when merging these pieces; it's possible that one could inadvertently revert parts of another because there is some overlap. |
51 tasks
BioTurboNick
force-pushed
the
hvncat-fixes-3
branch
from
c054525 to
588cb14
Compare
BioTurboNick
force-pushed
the
hvncat-fixes-3
branch
from
588cb14 to
891a316
Compare
82 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jul 19, 2021
KristofferC
pushed a commit
that referenced
this pull request
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking down #41143 into smaller pieces.
This adds stronger argument checks.