Fix inability to find support/{platform,dirpath}.h from julia_fasttls.h. #41308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During PackageCompiler.jl system image creation under Julia 1.7, gcc complains that it cannot find
support/{platform,dirpath}.h
included fromjulia_fasttls.h
(while looking inusr/include/julia
). My (potentially incorrect) working understanding is that all ofjulia_fasttls.h
and{platform,dirpath}.h
end up directly inusr/include/julia
--- i.e. thesupport/
qualification ofsupport/{platform,dirpath}.h
effectively gets flattened away when{platform,dirpath}.h
are copied fromsrc/support/{platform,dirpath}.h
tousr/include/julia
. This patch drops thesupport/
qualification in the include injulia_fasttls.h
, which locally seems to make everything happy (though I imagine this may not be the best or even a generally correct approach). Best! :)