Skip to content

Always send log messages to stderr by default #41653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Always send log messages to stderr by default #41653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/logging.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ function handle_message(logger::SimpleLogger, level::LogLevel, message, _module,
buf = IOBuffer()
stream = logger.stream
if !isopen(stream)
stream = level < Warn ? stdout : stderr
stream = stderr
end
iob = IOContext(buf, stream)
levelstr = level == Warn ? "Warning" : string(level)
Expand Down
2 changes: 1 addition & 1 deletion stdlib/Logging/src/ConsoleLogger.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ function handle_message(logger::ConsoleLogger, level::LogLevel, message, _module
msglines = [(indent=0, msg=l) for l in split(chomp(string(message)::String), '\n')]
stream = logger.stream
if !isopen(stream)
stream = level < Warn ? stdout : stderr
stream = stderr
end
dsize = displaysize(stream)::Tuple{Int,Int}
nkwargs = length(kwargs)::Int
Expand Down
16 changes: 1 addition & 15 deletions test/corelogging.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,20 +341,6 @@ end
String(take!(io))
end

function genmsg_out(level, message, _module, filepath, line; kws...)
fname = tempname()
f = open(fname, "w")
logger = SimpleLogger()
redirect_stdout(f) do
handle_message(logger, level, message, _module, :group, :id,
filepath, line; kws...)
end
close(f)
buf = read(fname)
rm(fname)
String(buf)
end

function genmsg_err(level, message, _module, filepath, line; kws...)
fname = tempname()
f = open(fname, "w")
Expand All @@ -370,7 +356,7 @@ end
end

# Simple
@test genmsg_out(Info, "msg", Main, "some/path.jl", 101) ==
@test genmsg_err(Info, "msg", Main, "some/path.jl", 101) ==
"""
┌ Info: msg
└ @ Main some/path.jl:101
Expand Down