inference: add missing LimitedAccuracy handlings
#42034
Merged
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found we need to handle `LimitedAccuracy` (i.e. collect its limitations into the current frame and unwrap its type) whenever we do inter-procedural inference. Especially, we need to handle it where we use `abstract_call_method` and `abstract_call_method_with_const_args`. Otherwise we may encounter nested `LimitedAccuracy`, which is really not expected. So this commit also adds the assertion that checks we never form nested `LimitedAccuracy`. I encountered errors due to this when analyzing JET itself by JET, probably because its codebase makes heavy use of `invoke`. I couldn't pack them up as simple test cases though.
vtjnash
approved these changes
Aug 27, 2021
|
Should be backported to 1.7. |
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Aug 28, 2021
63 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 31, 2021
I found we need to handle `LimitedAccuracy` (i.e. collect its limitations into the current frame and unwrap its type) whenever we do inter-procedural inference. Especially, we need to handle it where we use `abstract_call_method` and `abstract_call_method_with_const_args`. Otherwise we may encounter nested `LimitedAccuracy`, which is really not expected. So this commit also adds the assertion that checks we never form nested `LimitedAccuracy`. I encountered errors due to this when analyzing JET itself by JET, probably because its codebase makes heavy use of `invoke`. I couldn't pack them up as simple test cases though. (cherry picked from commit 6341fa5)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
I found we need to handle `LimitedAccuracy` (i.e. collect its limitations into the current frame and unwrap its type) whenever we do inter-procedural inference. Especially, we need to handle it where we use `abstract_call_method` and `abstract_call_method_with_const_args`. Otherwise we may encounter nested `LimitedAccuracy`, which is really not expected. So this commit also adds the assertion that checks we never form nested `LimitedAccuracy`. I encountered errors due to this when analyzing JET itself by JET, probably because its codebase makes heavy use of `invoke`. I couldn't pack them up as simple test cases though.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
I found we need to handle `LimitedAccuracy` (i.e. collect its limitations into the current frame and unwrap its type) whenever we do inter-procedural inference. Especially, we need to handle it where we use `abstract_call_method` and `abstract_call_method_with_const_args`. Otherwise we may encounter nested `LimitedAccuracy`, which is really not expected. So this commit also adds the assertion that checks we never form nested `LimitedAccuracy`. I encountered errors due to this when analyzing JET itself by JET, probably because its codebase makes heavy use of `invoke`. I couldn't pack them up as simple test cases though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found we need to handle
LimitedAccuracy(i.e. collect itslimitations into the current frame and unwrap its type) whenever
we do inter-procedural inference. Especially, we need to handle
it where we use
abstract_call_methodandabstract_call_method_with_const_args.Otherwise we may encounter nested
LimitedAccuracy, which is really notexpected to exist. So this commit also adds the assertion that checks we never
form nested
LimitedAccuracy.I encountered errors due to this when analyzing JET by JET itself,
probably because its codebase makes heavy use of
invoke.I couldn't pack them up as simple test cases though.