Eagerly do boundscheck when indexing CartesianIndices with CartesianIndices #42235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnychen94
commented
Sep 13, 2021
| CartesianIndices(getindex.(iter.indices, C.indices)) | ||
| getindex(iter, C.indices...) | ||
| end | ||
| @inline Base.getindex(iter::CartesianIndices{0}, ::CartesianIndices{0}) = iter |
There was a problem hiding this comment.
This method is used to override https://github.com/JuliaLang/julia/pull/42235/files#diff-48078500d9f5159df325b49822b85da1d8d43a8499807290d082406fba29e1cdR357-R359 to still get an array output because
getindex(iter, C.indices...) will degraded to getindex(iter) if iter <: CartesianIndices{0}.
mbauman
approved these changes
Sep 13, 2021
johnnychen94
force-pushed
the
jc/boundscheck_cartesion
branch
from
fc5b905 to
c69e46d
Compare
|
c69e46d is a rebase on master without any new changes. |
DilumAluthge
removed
the
merge me
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #42119