Fix bug and add tests for Bidiagonal #42354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
test
andreasnoack
approved these changes
Sep 23, 2021
dkarrasch
approved these changes
Sep 23, 2021
|
Backport? |
|
If you like, I don't see a reason not to but I'm not current with the release schedule |
|
Sorry, what I mean was, is it also applicable to earlier releases or is it something new. If it is applicable, it should ideally be backported since it is a bugfix. |
|
No need to backport. The bug was introduced in #41297 by me. |
KristofferC
pushed a commit
that referenced
this pull request
Sep 28, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this
xvariable was undefined. Also added some tests.