optimizer: fix #42840, the performance regression introduced by #42766 #42841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
added
embarrassing-bugfix
|
I guess this should also be backported to 1.7? |
|
Ah, yes, we should. |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
It seems like the allocation regression has gone (I also confirmed on my machine). Should be good to go. |
aviatesk
added a commit
that referenced
this pull request
Oct 29, 2021
This was referenced Oct 29, 2021
DilumAluthge
removed
the
merge me
aviatesk
added a commit
that referenced
this pull request
Oct 30, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excited to tag the "embrassing-bugfix" label for the first time..
I will make a simple test case.
@nanosoldier
runbenchmarks("union" || "array", vs="@2e388e3731fcdd8d1db4c1aed5c6a39df3ef7153")