choosetests: add the --force-net option, which will throw an error if networking is unavailable
#42889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r if networking is unavailable
DilumAluthge
added
ci
staticfloat
approved these changes
Nov 1, 2021
This was referenced Nov 7, 2021
|
Doesn't work on 1.6. |
daviehh
pushed a commit
to daviehh/julia
that referenced
this pull request
Nov 16, 2021
…r if networking is unavailable (JuliaLang#42889) (cherry picked from commit 31b9fd2)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…r if networking is unavailable (JuliaLang#42889)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…r if networking is unavailable (JuliaLang#42889)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you run
Base.runtests(["all"]), if networking is unavailable, it will print a warning and skip the test sets that requiring networking.However, in some settings (e.g. CI), this is undesirable. In CI, if networking is unavailable, we want to throw an error so that the CI job fails, which gets our attention and lets us know that we need to fix something in the CI environments.
This PR adds the
--force-netoption, which can be used like e.g.Base.runtests(["all", "--force-net"]). When the--force-netoption is passed, if networking is unavailable, an error is thrown.