Skip to content

[libjulia-codegen] export jl_jit_total_bytes #43086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2021
Merged

[libjulia-codegen] export jl_jit_total_bytes #43086

merged 3 commits into from
Nov 16, 2021

Conversation

inkydragon
Copy link
Member

@inkydragon inkydragon commented Nov 15, 2021 •
edited
Loading

fix #43077

Is this function part of the julia API?
Should I add a test for it?

@JeffBezanson
Copy link
Member

Yes, I guess we might as well have at least a simple test like @test Base.jit_total_bytes() >= 0.

Sacha0
Sacha0 approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @inkydragon! :)

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Nov 16, 2021
@DilumAluthge DilumAluthge merged commit 73f46aa into JuliaLang:master Nov 16, 2021
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Nov 16, 2021
@oscardssmith
Copy link
Member

does this need a backport?

@inkydragon
Copy link
Member Author

In 1.6.3 & 1.7.0-rc3, Base.jit_total_bytes() works fine.

@inkydragon inkydragon deleted the jit_total_bytes branch November 18, 2021 05:00
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@inkydragon @LilithHafner
[libjulia-codegen] export jl_jit_total_bytes (JuliaLang#43086)
c503e40
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@inkydragon @LilithHafner
[libjulia-codegen] export jl_jit_total_bytes (JuliaLang#43086)
dc23343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@JeffBezanson JeffBezanson JeffBezanson approved these changes

+1 more reviewer

@Sacha0 Sacha0 Sacha0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base.jit_total_bytes broken
6 participants
@inkydragon @JeffBezanson @oscardssmith @vtjnash @Sacha0 @DilumAluthge