improve error message when module of package is not the same as the package #43158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been considering how we might be able to remove this problem entirely |
DilumAluthge
added
error messages
Co-authored-by: Dilum Aluthge <[email protected]>
ararslan
reviewed
Nov 20, 2021
Co-authored-by: Alex Arslan <[email protected]>
DilumAluthge
approved these changes
Nov 21, 2021
|
Any objections to merging this? |
|
I think it is an improved user experience for now so I would say it could be merged. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…ackage (JuliaLang#43158) Co-authored-by: Dilum Aluthge <[email protected]> Co-authored-by: Alex Arslan <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…ackage (JuliaLang#43158) Co-authored-by: Dilum Aluthge <[email protected]> Co-authored-by: Alex Arslan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.