Skip to content

fix atomic getfield with boundcheck on interpreter #43602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

fix atomic getfield with boundcheck on interpreter #43602

merged 1 commit into from
Jan 5, 2022

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Dec 30, 2021 •
edited
Loading

Also introduces some error checks for atomic getfield with boundscheck in inference. Separated to #43651.

@aviatesk aviatesk requested a review from vtjnash December 30, 2021 05:31
@aviatesk aviatesk force-pushed the avi/getfield branch 2 times, most recently from 0a59fc9 to 22cf503 Compare December 30, 2021 07:29
@aviatesk aviatesk mentioned this pull request Jan 4, 2022
Merged
@JeffBezanson JeffBezanson added the bugfix This change fixes an existing bug label Jan 5, 2022
@JeffBezanson JeffBezanson merged commit 368a8f3 into master Jan 5, 2022
@JeffBezanson JeffBezanson deleted the avi/getfield branch January 5, 2022 19:31
KristofferC pushed a commit that referenced this pull request Jan 10, 2022
@aviatesk @KristofferC
fix atomic getfield with boundcheck on interpreter (#43602)
2c65083 
(cherry picked from commit 368a8f3)
@KristofferC KristofferC mentioned this pull request Jan 10, 2022
Merged
23 tasks
vtjnash
vtjnash reviewed Jan 10, 2022
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@aviatesk @LilithHafner
fix atomic getfield with boundcheck on interpreter (JuliaLang#43602)
b286149
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@aviatesk @LilithHafner
fix atomic getfield with boundcheck on interpreter (JuliaLang#43602)
61bd325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aviatesk @vtjnash @JeffBezanson @KristofferC