Skip to content

Regenerate all the checksums #44275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Regenerate all the checksums #44275

merged 1 commit into from
Feb 21, 2022

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Feb 20, 2022

I ran the entire checksum script (mainly to pick up the libblastrampoline update) and noted a bunch of other things the script modified. I figure it is best to update it wholesale with the output of the script on all the deps.

It also created deps/checksums/llvmunwind, which was not already checked in and is added in here.

MPFR in Versions.make was out of sync with MPFR_jll in the stdlibs.

@ViralBShah ViralBShah added the building Build system, or building Julia or its dependencies label Feb 20, 2022
@giordano
Copy link
Member

It also created deps/checksums/llvmunwind, which was not already checked in and is added in here.

There is an empty deps/checksums/llvmunwind and the llvm libunwind checksums were added to deps/checksums/unwind. Is that right?

@ViralBShah
Copy link
Member Author

ViralBShah commented Feb 20, 2022

I didn't pay too much attention to that. I just assumed the auto-generate script will do the right thing. It is possible the script needs updating. Maybe the unwind target needs some cleanup.

@DilumAluthge
Copy link
Member

@ViralBShah Can you post the exact make invocations that you ran?

@vtjnash It sounds like the refresh_checksums script is not packing the libunwind checksums into the correct file?

@ViralBShah
Copy link
Member Author

On a clean clone of julia, I ran

make -f contrib/refresh_checksums.mk  -j

@ViralBShah
Copy link
Member Author

deps/unwind.mk is where all the llvmunwind stuff is. Perhaps that file should be called deps/llvmunwind.mk?

@DilumAluthge
Copy link
Member

Maybe the refresh_checksums.mk script doesn't work when run in parallel? Can you try in a fresh clone of Julia without the -j?

If that fixes the problem, then we should add .NOTPARALLEL: to the top of that script.

@ViralBShah
Copy link
Member Author

ViralBShah commented Feb 20, 2022

Ok, how does this look now? I definitely think the script needs a .NOTPARALLEL. Would be nice to regenerate these automatically, but it takes a long time to run. Maybe we can do it every once in a while.

@DilumAluthge
Copy link
Member

It's still creating deps/checksums/llvmunwind, but I think those checksums should be going into deps/checksums/unwind alongside the Nongnu Unwind checksums. That is, I think we want to store all the unwind library checksums in the same file.

@DilumAluthge
Copy link
Member

@vtjnash Is there an extra command that Viral needs to run to pack all the unwind checksums into a single file?

@vtjnash
Copy link
Member

vtjnash commented Feb 20, 2022

That sounds odd. They should definitely be ending up in different files by following the rules (even in parallel). I don't know how that got out of sync, but once out of sync, it can remain a bit confused.

Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look reasonable to me. The goal in the future is that any PR updating one of these files should likely be updating every single line in the file. That makes confirmation easy and minimizes cross-PR contamination.

@ViralBShah ViralBShah merged commit ac922b0 into master Feb 21, 2022
@ViralBShah ViralBShah deleted the vs/checksums branch February 21, 2022 15:04
@ViralBShah ViralBShah added the backport 1.8 Change should be backported to release-1.8 label Feb 24, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
KristofferC pushed a commit that referenced this pull request Mar 3, 2022
(cherry picked from commit ac922b0)
@KristofferC KristofferC mentioned this pull request Mar 3, 2022
47 tasks
KristofferC pushed a commit that referenced this pull request Mar 7, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants