-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Regenerate all the checksums #44275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate all the checksums #44275
Conversation
There is an empty |
I didn't pay too much attention to that. I just assumed the auto-generate script will do the right thing. It is possible the script needs updating. Maybe the unwind target needs some cleanup. |
@ViralBShah Can you post the exact @vtjnash It sounds like the |
On a clean clone of julia, I ran
|
|
Maybe the If that fixes the problem, then we should add |
c8351df
to
cbb3afd
Compare
cbb3afd
to
8d9815b
Compare
Ok, how does this look now? I definitely think the script needs a |
It's still creating |
@vtjnash Is there an extra command that Viral needs to run to pack all the unwind checksums into a single file? |
That sounds odd. They should definitely be ending up in different files by following the rules (even in parallel). I don't know how that got out of sync, but once out of sync, it can remain a bit confused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look reasonable to me. The goal in the future is that any PR updating one of these files should likely be updating every single line in the file. That makes confirmation easy and minimizes cross-PR contamination.
(cherry picked from commit ac922b0)
(cherry picked from commit ac922b0)
I ran the entire checksum script (mainly to pick up the libblastrampoline update) and noted a bunch of other things the script modified. I figure it is best to update it wholesale with the output of the script on all the deps.
It also created
deps/checksums/llvmunwind
, which was not already checked in and is added in here.MPFR in Versions.make was out of sync with MPFR_jll in the stdlibs.