Skip to content

Remove PTLS load inside JIT #44967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Remove PTLS load inside JIT #44967

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2060572
Remove PTLS load inside JIT
pchintalapudi Apr 13, 2022
92883a2
Merge branch 'master' into pc/no-ptls
DilumAluthge Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/debuginfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,6 @@ class JITObjectRegistry
std::function<uint64_t(const StringRef &)> getLoadAddress,
std::function<void*(void*)> lookupWriteAddress)
{
jl_ptls_t ptls = jl_current_task->ptls;
// This function modify codeinst->fptr in GC safe region.
// This should be fine since the GC won't scan this field.
int8_t gc_state = jl_gc_safe_enter(ptls);

object::section_iterator EndSection = Object.section_end();

#ifdef _CPU_ARM_
Expand Down Expand Up @@ -378,7 +373,6 @@ class JITObjectRegistry
}
});
}
jl_gc_safe_leave(ptls, gc_state);
}

std::map<size_t, ObjectInfo, revcomp>& getObjectMap() JL_NOTSAFEPOINT
Expand Down