Allow constprop to improve constant results to Bottom #45146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
approved these changes
May 2, 2022
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
reviewed
May 2, 2022
This is consistent with what we would do for a non-constant return. This helps the compiler dump less code onto LLVM in situations where there is a big basic block that our constprop can see is dead. That said, for that particular situation, it might be better to have a constant propagation pass at the IR level that runs after inlining. We can revisit that after #44660.
vtjnash
reviewed
May 3, 2022
| add_remark!(interp, sv, "[constprop] Disabled by entry heuristic (unimprovable return type)") | ||
| if isa(rt, Const) | ||
| if result.edge_effects.nothrow !== ALWAYS_TRUE | ||
| # Could still be improved to Bottom (or at least could see the effects improved) |
There was a problem hiding this comment.
This seems specifically the case that function was intended to ignore as a possibility. I think a more correct version of this PR would be removing this function entirely, and remarking here only that we do const_prop as a pre-inlining optimization, so the return result is irrelevant to whether it may improve the quality of the inlined code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with what we would do for a non-constant return.
This helps the compiler dump less code onto LLVM in situations
where there is a big basic block that our constprop can see is
dead. That said, for that particular situation, it might be better
to have a constant propagation pass at the IR level that runs
after inlining. We can revisit that after #44660.