Skip to content

make floating point pow tests better #45325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2022
Merged

make floating point pow tests better #45325

merged 3 commits into from
May 17, 2022

Conversation

oscardssmith
Copy link
Member

previously the tests were too lenient for Float16 and Float32, and too strict for powers of -2 or 3 #45289 (comment)

@oscardssmith oscardssmith added test This change adds or pertains to unit tests maths Mathematical functions labels May 16, 2022
KristofferC
KristofferC reviewed May 16, 2022
View reviewed changes
KristofferC
KristofferC reviewed May 16, 2022
View reviewed changes
@KristofferC
Copy link
Member

KristofferC commented May 16, 2022 •
edited
Loading

Would be good with slightly more descriptive commit message.

@oscardssmith oscardssmith changed the title make tests better make floating point pow tests better May 16, 2022
oscarddssmith added 2 commits May 16, 2022 14:17
@oscardssmith oscardssmith merged commit ab4d060 into JuliaLang:master May 17, 2022
@oscardssmith oscardssmith deleted the better-floating-point-pow-tests branch May 17, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
maths Mathematical functions test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscardssmith @KristofferC