-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Update LibCURL to 7.83.1 #45443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LibCURL to 7.83.1 #45443
Conversation
LibCURL-fd8af649b38ae20c3ff7f5dca53753512ca00376.tar.gz/md5/f082283e6a35fcba5b63c9a6219d8003 | ||
LibCURL-fd8af649b38ae20c3ff7f5dca53753512ca00376.tar.gz/sha512/3bea5fa3fb6d29651daa923ae6bcb8eeb356ab9f2a1f3e005a6b746b617b0cf609aed4cadda4181783959840873c04b18e34e45ab973549169d19775a05ea01e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new file is missing these two lines, and the failure at the end of the build job I guess is related to this. But I don't know how these two checksums should come from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered what to do with stdlib/LibCURL.version
, but I have how idea how it relates to the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, LibCURL.jl
is the standard libraries whose source code is pulled from an external repository:
Lines 1 to 4 in 86f5501
LIBCURL_BRANCH = master | |
LIBCURL_SHA1 = fd8af649b38ae20c3ff7f5dca53753512ca00376 | |
LIBCURL_GIT_URL := https://github.com/JuliaWeb/LibCURL.jl.git | |
LIBCURL_TAR_URL = https://github.com/api/repos/JuliaWeb/LibCURL.jl/tarball/$1 |
I have restored the two checksum lines, but running |
Musl error (https://buildkite.com/julialang/julia-master/builds/12338#f932a979-6bf1-41c1-98f2-fb2e20a3f5c2/466-2043) looks real:
|
@tp2750 was interested in adding support for kerberos, but didn't follow up with adding the stdlib to Julia |
I'm not clear on what I need to do. My interest is to have a kerberos enabled libCurl in Yggdrasil. Apparently this has some interaction with the libCurl in Julia itself, but honestly I don't have full understanding of these interactions. |
If I understand well, either kerberos is added to the dependencies of Julia on linux and freebsd (but what is the benefit for that extra dependency), or JuliaPackaging/Yggdrasil#4774 is reverted. |
The benefit of having a Kerberos enabled libCurl in Julia is to be able to access web services behind a Kerberos authentication. After adding Kerberos support to LibPQ.jl I thought it would be equally easy to fix it for libCurl. Apparently this is not the case, as Julia carries it's own copy of libCurl. I will be happy to try and fix this, but I need some guidance, as I do not fully understand how these things interact. After the merge of JuliaPackaging/Yggdrasil#4774 I did a fresh build of Julia main and could see that Kerberos support in libCurl was working, so I thought all was good. |
I do not know what the Julia policy is, or who can make a decision here, but this is blocking the update, while there are 7 known vulnerabilities in curl 7.81.0: https://curl.se/docs/vuln-7.81.0.html |
I'll revert kerberos in Yggdrasil to unlock things here, but I won't be able to do it before tomorrow or Saturday. |
This new build doesn't depend on Kerberos
Thanks @giordano this looks good to go now |
This new build doesn't depend on Kerberos Co-authored-by: Mosè Giordano <[email protected]> (cherry picked from commit 28d9326)
This new build doesn't depend on Kerberos Co-authored-by: Mosè Giordano <[email protected]> (cherry picked from commit 28d9326)
This will be updated following the merging of JuliaPackaging/Yggdrasil#4942