NFC cosmetic cleanup for compiler code #45706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
KristofferC
reviewed
Jun 16, 2022
aviatesk
commented
Jun 17, 2022
Comment on lines
+1767
to
+1774
| if check # analyze implicit type asserts on argument and return type | ||
| ftt = closure.typ | ||
| (aty, rty) = (unwrap_unionall(ftt)::DataType).parameters | ||
| rty = rewrap_unionall(rty isa TypeVar ? rty.lb : rty, ftt) | ||
| if !(rt ⊑ rty && tuple_tfunc(arginfo.argtypes[2:end]) ⊑ rewrap_unionall(aty, ftt)) | ||
| effects = Effects(effects; nothrow=TRISTATE_UNKNOWN) | ||
| end | ||
| end |
There was a problem hiding this comment.
@Keno could you please confirm this implementation is correct?
The previous implementation is equivalent to
Suggested change
| if check # analyze implicit type asserts on argument and return type | |
| ftt = closure.typ | |
| (aty, rty) = (unwrap_unionall(ftt)::DataType).parameters | |
| rty = rewrap_unionall(rty isa TypeVar ? rty.lb : rty, ftt) | |
| if !(rt ⊑ rty && tuple_tfunc(arginfo.argtypes[2:end]) ⊑ rewrap_unionall(aty, ftt)) | |
| effects = Effects(effects; nothrow=TRISTATE_UNKNOWN) | |
| end | |
| end | |
| if check # analyze implicit type asserts on argument and return type | |
| ftt = closure.typ | |
| (aty, rty) = (unwrap_unionall(ftt)::DataType).parameters | |
| rty = rewrap_unionall(rty isa TypeVar ? rty.lb : rty, ftt) | |
| if rt ⊑ rty && tuple_tfunc(arginfo.argtypes[2:end]) ⊑ rewrap_unionall(aty, ftt) | |
| effects = Effects(effects; nothrow=TRISTATE_UNKNOWN) | |
| end | |
| end |
whose nothrow check is flipped I think.
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
* clean up `abstract_call_method` interface * tidy up `abstract_call_opaque_closure` interface * miscellaneous improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abstract_call_methodinterfaceabstract_call_opaque_closureinterface@nanosoldier
runbenchmarks("inference", vs=":master")