Create the new pass manager pipelines #46175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchintalapudi
added
compiler:codegen
pchintalapudi
force-pushed
the
pc/newpm_pipeline
branch
from
d9514db to
437c374
Compare
pchintalapudi
force-pushed
the
pc/newpm_pipeline
branch
from
437c374 to
5487563
Compare
pchintalapudi
commented
Jul 27, 2022
| } else { | ||
| MPM.addPass(RemoveNI()); | ||
| } | ||
| MPM.addPass(LowerSIMDLoop()); // TODO why do we do this twice |
There was a problem hiding this comment.
While translating our pass pipeline over to NewPM, I noticed that we're calling for LowerSIMDLoop to run twice in the pipeline if we're running at O1 or below. Is there a particular reason for this double run?
There was a problem hiding this comment.
No I think we should only run it once
vchuravy
approved these changes
Jul 27, 2022
|
The SparseArrays Win64 segfault is unrelated to this PR, and this PR doesn't really turn on any interesting functionality that could cause it anyways. |
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
* Create basic NewPM structures * Replace incidental uses of the legacy pass manager with the new pass manager * Run the MC emitter
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
* Create basic NewPM structures * Replace incidental uses of the legacy pass manager with the new pass manager * Run the MC emitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things to move us closer to using NewPM everywhere:
Much of the content of this PR was cribbed from #44365, just separating it out to merge the more unobjectionable parts first
Fix #44987.