Skip to content

Cover binomial cases for large K (BigInt) #48073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 28, 2023
Merged

Cover binomial cases for large K (BigInt) #48073

merged 16 commits into from
Feb 28, 2023
+20 −2

Conversation

originalsouth
Copy link
Contributor

Initial fix for #48072

@originalsouth
Cover binomial cases for large K (BigInt)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
ba2a753
fingolfin
fingolfin reviewed Jan 2, 2023
View reviewed changes
originalsouth and others added 2 commits January 2, 2023 14:37
@originalsouth
Cover more binomial cases for large K (BigInt)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
386c211
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
175b769
fingolfin
fingolfin reviewed Jan 2, 2023
View reviewed changes
originalsouth and others added 2 commits January 2, 2023 22:49
@originalsouth
Fix for BigInt binomial implementation

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
caed084
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
37ecf60
fingolfin
fingolfin reviewed Jan 2, 2023
View reviewed changes
originalsouth and others added 2 commits January 3, 2023 06:29
@originalsouth
One less potential allocation for BigInt binomial implementation

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
15018b6
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a2ffdc9
@originalsouth originalsouth marked this pull request as ready for review January 3, 2023 09:57
sostock
sostock reviewed Jan 4, 2023
View reviewed changes
originalsouth and others added 4 commits January 7, 2023 20:13
@originalsouth
UInt -> Culong for BigInt binomial functions

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
51091de
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
11c98d7
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6bba292
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cdee28b
@brenhinkeller brenhinkeller added the bignums BigInt and BigFloat label Jan 18, 2023
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
648f682
sostock
sostock reviewed Feb 16, 2023
View reviewed changes
originalsouth and others added 4 commits February 19, 2023 13:26
@originalsouth @sostock
Update base/gmp.jl as suggested "will" --> "would"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
05cb906 
Co-authored-by: Sebastian Stock <[email protected]>
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
febcb9a
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4b904a1
@originalsouth
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
35aba60
@ViralBShah
Copy link
Member

Good to merge?

@oscardssmith oscardssmith merged commit 832a67c into JuliaLang:master Feb 28, 2023
@originalsouth originalsouth mentioned this pull request Feb 28, 2023
Closed
@LilithHafner LilithHafner mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin

@sostock sostock

@oscardssmith oscardssmith

Assignees
No one assigned
Labels
bignums BigInt and BigFloat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@originalsouth @ViralBShah @fingolfin @oscardssmith @sostock @brenhinkeller