Skip to content

Add GC stat: total_time_to_safepoint #48867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2023
Merged

Add GC stat: total_time_to_safepoint #48867

merged 2 commits into from
Mar 21, 2023

Conversation

kpamnany
Copy link
Member

@kpamnany kpamnany commented Mar 2, 2023

Adds a useful GC statistic that counts the total time spent waiting for a safepoint.

Also fixes a typo from an earlier PR that added max_time_to_safepointp.

@gbaraldi
Copy link
Member

gbaraldi commented Mar 2, 2023

Maybe add a test?

@kpamnany
Copy link
Member Author

kpamnany commented Mar 2, 2023

There are no tests currently for any of the GC_Num statistics. Also, I don't see a way to verify correctness of any of the statistics. Tests that simply verify that the statistics are present/updated do not seem useful to me.

@gbaraldi
Copy link
Member

gbaraldi commented Mar 2, 2023 •
edited
Loading

Fair enough. Doesn't this need to be reset/set.

@kpamnany
Copy link
Member Author

kpamnany commented Mar 2, 2023

Like total_mark_time and total_sweep_time, I believe this is zeroed here, and never reset.

@kpamnany
Copy link
Member Author

kpamnany commented Mar 2, 2023

@KristofferC: can this be backported to 1.9.0? One of the commits is sort of a bug fix.

@KristofferC
Copy link
Member

@KristofferC: can this be backported to 1.9.0? One of the commits is sort of a bug fix.

image

@kpamnany
Copy link
Member Author

kpamnany commented Mar 6, 2023

The test failure seems unrelated. Bump?

@kpamnany
Copy link
Member Author

kpamnany commented Mar 9, 2023

Now a Sockets failure. 🤯 Still unrelated I think.

@kpamnany
Copy link
Member Author

Okay, green now. Too many flaky tests!

Is this good then? Can we merge? And can we backport?

@DilumAluthge DilumAluthge requested a review from gbaraldi March 11, 2023 14:31
@DilumAluthge DilumAluthge added the don't squash Don't squash merge label Mar 11, 2023
@kpamnany
Copy link
Member Author

And can we backport it after all, @KristofferC, or was the meme intended to be a kind way to say "no!"? ;)

@vchuravy
Copy link
Member

vchuravy commented Mar 16, 2023 •
edited
Loading

@DilumAluthge why the "don't squash"?

@kpamnany rebase is prefered over merge to update a branch to keep the history linear.

@DilumAluthge
Copy link
Member

One of the commits is sort of a bug fix.

So I figured we want to backport the single commit that is a bug fix, but we don't want to backport the entire PR.

@kpamnany
Copy link
Member Author

Bump.

@vchuravy vchuravy merged commit 3e96c76 into master Mar 21, 2023
@vchuravy vchuravy deleted the kp/add-gc-ttsp branch March 21, 2023 18:14
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request May 12, 2023
@vchuravy @kpamnany
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
f3e0914 
Add GC stat: `total_time_to_safepoint`
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 7, 2023
@vchuravy @kpamnany
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
b38814f 
Add GC stat: `total_time_to_safepoint`
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 22, 2023
@vchuravy @kpamnany
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
d329031 
Add GC stat: `total_time_to_safepoint`
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jun 29, 2023
@vchuravy @kpamnany
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
909094c 
Add GC stat: `total_time_to_safepoint`
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jul 6, 2023
@vchuravy @kpamnany
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
1404700 
Add GC stat: `total_time_to_safepoint`
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jul 27, 2023
@vchuravy @kpamnany
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
4ff192c 
Add GC stat: `total_time_to_safepoint`
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Aug 21, 2023
@vchuravy @kpamnany
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
55186f9 
Add GC stat: `total_time_to_safepoint`
quinnj pushed a commit to RelationalAI/julia that referenced this pull request Sep 5, 2023
@vchuravy @quinnj
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
318aa6b 
Add GC stat: `total_time_to_safepoint`
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Sep 28, 2023
@vchuravy
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
9ee1ecb 
Add GC stat: `total_time_to_safepoint`
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 1, 2023
@vchuravy
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
778ba31 
Add GC stat: `total_time_to_safepoint`
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 12, 2023
@vchuravy
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
f98b53e 
Add GC stat: `total_time_to_safepoint`
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 14, 2023
@vchuravy
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
b776c10 
Add GC stat: `total_time_to_safepoint`
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 17, 2023
@vchuravy
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
4061e2f 
Add GC stat: `total_time_to_safepoint`
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 18, 2023
@vchuravy
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
8a3e53c 
Add GC stat: `total_time_to_safepoint`
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Oct 18, 2023
@vchuravy @kpamnany
Merge pull request JuliaLang#48867 from JuliaLang/kp/add-gc-ttsp
d30704c 
Add GC stat: `total_time_to_safepoint`
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Oct 19, 2023
@vchuravy @kpamnany
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
23f2bbd
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 20, 2023
@vchuravy
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
18714e1
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Oct 21, 2023
@vchuravy @kpamnany
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
df364be
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Oct 23, 2023
@vchuravy
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
694b967
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 1, 2023
@vchuravy
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
47fa087
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 2, 2023
@vchuravy
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
be5a9e0
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 7, 2023
@vchuravy
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
c766920
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 10, 2023
@vchuravy
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
5a7e62d
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 14, 2023
@vchuravy
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
3fed8ab
DelveCI pushed a commit to RelationalAI/julia that referenced this pull request Nov 15, 2023
@vchuravy
Add GC stat: total_time_to_safepoint (JuliaLang#48867)
a58c832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

@gbaraldi gbaraldi gbaraldi approved these changes

Assignees
No one assigned
Labels
don't squash Don't squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kpamnany @gbaraldi @KristofferC @vchuravy @DilumAluthge