Reduce unnecessary task stickiness #49601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
May 2, 2023
kpamnany
force-pushed
the
kp/channel-task-fix
branch
from
9a33b53 to
0cfd6f2
Compare
kpamnany
force-pushed
the
kp/channel-task-fix
branch
from
0cfd6f2 to
9dbfc05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks are created sticky by default. Task stickiness also spreads, and tasks do not get "unstickied". Until that can be fixed, we need to avoid introducing any unnecessary stickiness.
This PR removes one case:
binding a task to aChannelcreates a task to close the channel which does not need to be sticky. It also fixes a potential race.