Skip to content

TimeType subtraction using promote #49700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2023
Merged

TimeType subtraction using promote #49700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stdlib/Dates/src/arithmetic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
# TimeType arithmetic
(+)(x::TimeType) = x
(-)(x::T, y::T) where {T<:TimeType} = x.instant - y.instant
(-)(x::TimeType, y::TimeType) = -(promote(x, y)...)

# Date-Time arithmetic
"""
Expand Down
7 changes: 7 additions & 0 deletions stdlib/Dates/test/arithmetic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ using Dates
b = Dates.Time(11, 59, 59)
@test Dates.CompoundPeriod(a - b) == Dates.Hour(12)
end

@testset "TimeType arithmetic" begin
a = Date(2023, 5, 1)
b = DateTime(2023, 5, 2)
@test b - a == Day(1)
end

@testset "Wrapping arithmetic for Months" begin
# This ends up being trickier than expected because
# the user might do 2014-01-01 + Month(-14)
Expand Down