Use top_set_bit to optimize hash(Real)
#49986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
approved these changes
May 29, 2023
|
CI seems to be broken by this PR. Please revert this. |
KristofferC
pushed a commit
that referenced
this pull request
May 30, 2023
This reverts commit 18d02c2.
|
Sorry about that. Thank you for reverting. |
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not affect computed hash values (the num == 0 case is covered earlier), simplify generated code, and,
on my machine, this results in a 1.5x speedup for hashing 128-bit integers according to
@btime hash(x) setup=(x=rand(Int128)).