Stack allocate unsafe_load() and unsafe_store!() for Ptr to immutable.
#50244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test that this doesn't allocate. The test fails on master, and passes after this commit.
This also **fixes a crash** caused by illegal instruction. See: #50243 (comment)
NHDaly
changed the title
unsafe_load() Ptr to immutable.unsafe_load() and unsafe_store!() for Ptr to immutable.
|
Replaced by #50164 (sorry for the duplicate work!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50243.
Stack allocate the struct we dereference from
unsafe_load(), when it is a Ptr to an immutable.Also make the same fix to codegen for
unsafe_store!()on non-isbits immutables.This also fixes a crash caused by illegal instruction.
See: #50243 (comment)
Also adds tests that these don't allocate, and that it doesn't crash.
The tests fail on master, and pass after this commit.