Skip to content

Revert "Support rounding Irrationals" #50835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Support rounding Irrationals" #50835

wants to merge 1 commit into from

Conversation

Seelengrab
Copy link
Contributor

@Seelengrab Seelengrab commented Aug 8, 2023 •
edited
Loading

Reverts #45598

See the discussion in #50812 and #42060

@theabhirath The original PR for Irrational was otherwise a good idea, so having methods for round specializing on Irrational would still be cool to have. I'd be happy to review if you're up for it!

@brenhinkeller brenhinkeller added the maths Mathematical functions label Aug 8, 2023
@Seelengrab
Copy link
Contributor Author

4/6 of the test failures are timeouts, FreeBSD errored due to some Libdl stuff and mingw32 # Received cancellation signal, interrupting. Should be unrelated to the revert.

@LilithHafner LilithHafner added the revert This reverts a previously merged PR. label Aug 8, 2023
@theabhirath
Copy link
Contributor

Reverts #45598

See the discussion in #50812 and #42060

@theabhirath The original PR for Irrational was otherwise a good idea, so having methods for round specializing on Irrational would still be cool to have. I'd be happy to review if you're up for it!

Ah, I just saw this. If I understand correctly, the widening of the function signatures upto Real seems to be the discussion, and so it might be more helpful right now to just re-land a PR after this one where the function signatures are limited to Irrational?

@Seelengrab
Copy link
Contributor Author

Yep, that's the idea!

@Seelengrab
Copy link
Contributor Author

Is there anything to be done here to get this merged? Not sure who to ping/ask here..

@Seelengrab Seelengrab mentioned this pull request Aug 31, 2023
Merged
@Seelengrab Seelengrab closed this Sep 1, 2023
@Seelengrab
Copy link
Contributor Author

Closing since the refactor in #50812 in combination with #51141 makes this revert obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maths Mathematical functions revert This reverts a previously merged PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Seelengrab @theabhirath @brenhinkeller @LilithHafner