Skip to content

Conversation

KristofferC
Copy link
Member

This is a version of #51432 that does not have the method world age hack to make it non-breaking. This is to discover (through PkgEval) what packages rely on Random being in the sysimage and should be updated. Even if #51432 is non-breaking, there is some invalidation cost in using the methods without relying on Random so it is still better to have these packages fixed.

@KristofferC KristofferC added the DO NOT MERGE Do not merge this PR! label Oct 18, 2023
@KristofferC
Copy link
Member Author

@nanosoldier runtests()

@DilumAluthge DilumAluthge marked this pull request as draft October 18, 2023 13:46
@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@KristofferC
Copy link
Member Author

KristofferC commented Oct 20, 2023


  • Tetris ~/.julia/packages/Tetris/opDGZ/src/Tetris.jl:1
  • PointInPoly /PointInPoly/LgolM/src/pinpoly.jl:1
  • StressTest a/packages/StressTest/afsIh/src/StressTest.jl:21
  • Bobby Bobby ~/.julia/packages/Bobby/BLIkF/src/magic.jl:48: Add Random as a dependency alemelis/Bobby.jl#31
  • OwnTime s/OwnTime/x2dvv/test/runtests.jl:5
  • PathDistribution lia/packages/PathDistribution/ZGjur/src/monte_carlo.jl:132

@KristofferC
Copy link
Member Author

We have the list now at least

@oscardssmith
Copy link
Member

is the plan now to PR all of these repos?

@vchuravy vchuravy deleted the kc/random_sysimage branch February 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Do not merge this PR!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants