Skip to content

Fix generic triangular solves with empty matrices #54201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix generic triangular solves with empty matrices #54201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stdlib/LinearAlgebra/src/triangular.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,6 +1296,7 @@ function generic_trimatdiv!(C::AbstractVecOrMat, uploc, isunitc, tfun::Function,
if size(C) != size(B)
throw(DimensionMismatch(lazy"size of output, $(size(C)), does not match size of right hand side, $(size(B))"))
end
iszero(mA) && return C
oA = oneunit(eltype(A))
@inbounds if uploc == 'U'
if isunitc == 'N'
Expand Down Expand Up @@ -1432,6 +1433,7 @@ function generic_trimatdiv!(C::AbstractVecOrMat, uploc, isunitc, ::Function, xA:
if size(C) != size(B)
throw(DimensionMismatch(lazy"size of output, $(size(C)), does not match size of right hand side, $(size(B))"))
end
iszero(mA) && return C
oA = oneunit(eltype(A))
@inbounds if uploc == 'U'
if isunitc == 'N'
Expand Down
13 changes: 13 additions & 0 deletions stdlib/LinearAlgebra/test/lu.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,4 +486,17 @@ end
LinearAlgebra.generic_lufact!(fill(Inf, 2, 2), check=false)
end

@testset "lu for empty matrices" begin
for T in (Float64, BigFloat)
A = fill(T(0.0), 0, 0)
v = fill(T(1.0), 0, 10)
@test A \ v ≈ lu(A) \ v
vt = permutedims(v)
@test vt / A ≈ vt / lu(A)
B = UpperTriangular(transpose(fill(complex(T(0.0)), 0, 0)'))
@test B \ v ≈ v
@test vt / B ≈ vt
end
end

end # module TestLU