rename variable used in inbounds to avoid accidental collisions due to macro hygiene bug
#54613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue to macry hygiene bug
KristofferC
force-pushed
the
kc/macro_mixups
branch
from
fd8fe07 to
fb6f579
Compare
Keno
reviewed
May 29, 2024
| return Expr(:block, | ||
| Expr(:inbounds, true), | ||
| Expr(:local, Expr(:(=), :val, esc(blk))), | ||
| Expr(:local, Expr(:(=), :val_49f6338b, esc(blk))), |
There was a problem hiding this comment.
gensym? But as was pointed out in the original issue, the macro is fine as written, the current behavior is a bug. Maybe leave a comment that effect?
There was a problem hiding this comment.
gensym is not defined during bootstrapping so this seemed easiest.
There was a problem hiding this comment.
This is off-topic, but I wonder if reserved words might be useful in these cases. cf. (PR #51215)
Of course, we still need to be careful to avoid collisions in Base and stdlibs.
giordano
reviewed
May 29, 2024
Seelengrab
reviewed
May 29, 2024
| end | ||
| end | ||
|
|
||
| @testset "inbounds hygien confusion" begin |
There was a problem hiding this comment.
Suggested change
| @testset "inbounds hygien confusion" begin | |
| @testset "inbounds hygiene confusion" begin |
giordano
changed the title
variable used in inbounds to avoid accidental collisions due to macry hygiene bugvariable used in inbounds to avoid accidental collisions due to macro hygiene bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54417