Skip to content

Revert changing wrap on Memory to view and make wrap non-public. #54927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 31, 2024
Merged

Revert changing wrap on Memory to view and make wrap non-public. #54927

merged 5 commits into from
Jul 31, 2024

Conversation

KristofferC
Copy link
Member

Fixes #54768

aviatesk
aviatesk reviewed Jun 26, 2024
View reviewed changes
@JeffBezanson JeffBezanson added this to the 1.11 milestone Jul 18, 2024
@KristofferC KristofferC removed this from the 1.11 milestone Jul 25, 2024
@KristofferC
Copy link
Member Author

This PR has been backported so changing milestone to 1.12.

@KristofferC KristofferC added this to the 1.12 milestone Jul 25, 2024
@KristofferC KristofferC mentioned this pull request Jul 26, 2024
Open
@KristofferC KristofferC merged commit 8d41d25 into master Jul 31, 2024
@KristofferC KristofferC deleted the kc/view_wrap_mem branch July 31, 2024 10:54
This was referenced Jul 31, 2024
Closed
Closed
lazarusA pushed a commit to lazarusA/julia that referenced this pull request Aug 17, 2024
@KristofferC @lazarusA
Revert changing wrap on Memory to view and make wrap non-publ…
5499794 
…ic. (JuliaLang#54927)

Fixes JuliaLang#54768
@MasonProtter
Copy link
Contributor

Is there a reason this is non-public instead of public but non-exported?

@KristofferC
Copy link
Member Author

Yes, it was more conservative and it wasn't clear if the name wrap or it's current functionality was the best.

@nsajko nsajko added arrays [a, r, r, a, y, s] revert This reverts a previously merged PR. labels Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk left review comments

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s] revert This reverts a previously merged PR.
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.

view(::Memory, ::UnitRange) should not create a Vector
6 participants
@KristofferC @MasonProtter @oscardssmith @aviatesk @JeffBezanson @nsajko