remove USAGE part of error message when using main macro #55037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
approved these changes
Jul 5, 2024
Seelengrab
reviewed
Jul 6, 2024
| macro main(args...) | ||
| if !isempty(args) | ||
| error("USAGE: `@main` is expected to be used as `(@main)` without macro arguments.") | ||
| error("`@main` is expected to be used as `(@main)` without macro arguments.") |
There was a problem hiding this comment.
In the interest of taking advantage of semantic errors, can this throw(ArgumentError(..)) instead?
There was a problem hiding this comment.
I'm not sure what errors one typically throws in macro expansions. I'll just do the current change for now.
There was a problem hiding this comment.
It's not really consistent across Base at the moment. When I reworked the error messages in Printf, I opted for ArgumentError because the error is about the arguments of a macro (see here). I guess this could change in the future though if/when macros get the fancy error messages Claire talked about at JuliaCon. I'll keep this in mind until then though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this error message and it felt someone was very angry at me 😢