precompile: Ensure CI has inference results available for jl_create_native
#55528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…native` `jl_ci_cache_lookup` is used to obtain a CI that will be handed to `jl_emit_codeinst` which expects inference results to be available. This problem was causing missing code when, e.g., compiling `NetworkOptions.__init__` using `--trim` (JuliaLang#55047).
vtjnash
reviewed
Aug 19, 2024
Fair enough - but that's a deeper problem and this is a significant improvement for now so I'll merge this. It would also be great to tighten up our handling of empty modules here. I don't know why we end up with an empty module sometimes (other than the caching issues introduced in v1.12) |
KristofferC
pushed a commit
that referenced
this pull request
Sep 12, 2024
…native` (#55528) `jl_emit_codeinst` expects inference results to be available, so `jl_ci_cache_lookup` needs to provide a CI that has them. I noticed this because it was causing missing code when, e.g., compiling `NetworkOptions.__init__` using `--trim` (#55047). Unfortunately `jl_emit_codeinst` failures are silently ignored (they just leave the LLVM module empty), so it was easy to miss that the looked-up CIs sometimes fail to compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jl_emit_codeinstexpects inference results to be available, sojl_ci_cache_lookupneeds to provide a CI that has them.I noticed this because it was causing missing code when, e.g., compiling
NetworkOptions.__init__using--trim(#55047). Unfortunatelyjl_emit_codeinstfailures are silently ignored (they just leave the LLVM module empty), so it was easy to miss that the looked-up CIs sometimes fail to compile.