-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Make BoundsError
lazy and move Memory
boundscheck to Julia
#56167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BoundsError
lazy and move Memory
boundscheck to JuliaBoundsError
lazy and move Memory
boundscheck to Julia
0acb6cd
to
bf20618
Compare
I tried to revive this PR (I can push my local changes if helpful, at least to resolve the merge conflict), but the problem is that
I don't quite know how to fix that, I don't know where |
see |
bf20618
to
195d8a1
Compare
In the meantime I pushed the commits to resolve the merge conflicts, but I didn't have a chance to look into the |
This is a revival of #43738 with a lot of changes. The biggest by far is that with this version of the PR, I'm trying to get the BoundsError to semantically not escape the input argument so that LLVM escape analysis doesn't see bounds error construction as a potential escape (motivated by #55913). That said, this will likely significantly increase IR size, so I'm not sure if it is worth it or if this is a good tradeoff...