Skip to content

Support native fma on riscv64 #57043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support native fma on riscv64 #57043

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ace70d
Support native `fma` on riscv64
giordano Jan 14, 2025
d6ace5e
Fix logic for setting have_fma on riscv64
giordano Jan 14, 2025
e8c9e71
Don't rely on required extensions for fma detection
giordano Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions src/llvm-cpufeatures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,24 @@ static bool have_fma(Function &intr, Function &caller, const Triple &TT) JL_NOTS
SmallVector<StringRef, 128> Features;
FS.split(Features, ',');
for (StringRef Feature : Features)
if (TT.isARM()) {
if (Feature == "+vfp4")
return typ == "f32" || typ == "f64";
else if (Feature == "+vfp4sp")
return typ == "f32";
} else if (TT.isX86()) {
if (Feature == "+fma" || Feature == "+fma4")
return typ == "f32" || typ == "f64";
}
if (TT.isARM()) {
if (Feature == "+vfp4")
return typ == "f32" || typ == "f64";
else if (Feature == "+vfp4sp")
return typ == "f32";
} else if (TT.isX86()) {
if (Feature == "+fma" || Feature == "+fma4")
return typ == "f32" || typ == "f64";
} else if (TT.isRISCV64()) {
// Don't return early if we find a known extension but it doesn't
// support the current type (e.g. f64 with Zfh or f16 with D)
if (Feature == "+zfh" && typ == "f16")
return true;
else if (Feature == "+d" && typ == "f64")
return true;
if (Feature == "+f" && typ == "f32")
return true;
}

return false;
}
Expand Down
Loading