Implement logic for feature detection piggy backing on LLVM's feature detection #57049
+254
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't switch or implement the new logic fully but I'm already opening for some comments if people have opinions.
The design is a bit more C++isy (this means removing c++ from the runtime is further away) and potentially less space efficient than the previous one (Not that it's very relevant).
The design switches to a clone targets logic that serializes a string like
cpu_name1;+feature1, +feature2; 0: cpu_name2; +feature3, +feature4; 0
This gets rid of the nice bitset logic that we have but hopefully LLVM can replace most of it