Skip to content

deps: update JuliaSyntax to v1.0.0 #57188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2025
Merged

deps: update JuliaSyntax to v1.0.0 #57188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1dfadd2
deps: update JuliaSyntax to v1.0.0
inkydragon Jan 26, 2025
5a2a0b6
deps: update JuliaSyntaxHighlighting
inkydragon Jan 29, 2025
6b243ca
test: update syntax tests
inkydragon Jan 29, 2025
a213bae
test: mark broken syntax tests
inkydragon Jan 29, 2025
601e395
test: fix syntax test `n37134`
inkydragon Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/JuliaSyntax.version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
JULIASYNTAX_BRANCH = main
JULIASYNTAX_SHA1 = dfd1d69b153eb119873035e62993a109b27192f0
JULIASYNTAX_SHA1 = 2e965a159dd9f87d216d2d50ecbd2ed4f9af2c5a
JULIASYNTAX_GIT_URL := https://github.com/JuliaLang/JuliaSyntax.jl.git
JULIASYNTAX_TAR_URL = https://github.com/api/repos/JuliaLang/JuliaSyntax.jl/tarball/$1
1 change: 1 addition & 0 deletions deps/checksums/JuliaSyntax-2e965a159dd9f87d216d2d50ecbd2ed4f9af2c5a.tar.gz/md5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
40d7bcc6e5741d50a457ace2ca8b2c0c
1 change: 1 addition & 0 deletions deps/checksums/JuliaSyntax-2e965a159dd9f87d216d2d50ecbd2ed4f9af2c5a.tar.gz/sha512
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
b9429b90a28460ef0272cd42a5c221629c6d60221ed088ae3e591cc3d8dbdec32788074397419e58b611bda7df32c7379ec7fafeead7056ed9665591474cec5d
1 change: 0 additions & 1 deletion deps/checksums/JuliaSyntax-dfd1d69b153eb119873035e62993a109b27192f0.tar.gz/md5
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion deps/checksums/JuliaSyntax-dfd1d69b153eb119873035e62993a109b27192f0.tar.gz/sha512
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions deps/checksums/JuliaSyntaxHighlighting-2680c8bde1aa274f25d7a434c645f16b3a1ee731.tar.gz/md5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
187f155c32a79f57a89e31e672d2d8c5
1 change: 1 addition & 0 deletions .../checksums/JuliaSyntaxHighlighting-2680c8bde1aa274f25d7a434c645f16b3a1ee731.tar.gz/sha512
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
69347af996d77b88b5e5b6e44ff046e9197775a66802a0da6fb5fcbf9e5ca533566955c8435bc25490f6ca0c002b4c1effcddaf932b7eb91e00a8f99554b7b8d
1 change: 0 additions & 1 deletion deps/checksums/JuliaSyntaxHighlighting-eb8097c5f1dbfca80b5e6664af031ff1fe0904af.tar.gz/md5
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .../checksums/JuliaSyntaxHighlighting-eb8097c5f1dbfca80b5e6664af031ff1fe0904af.tar.gz/sha512
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion stdlib/JuliaSyntaxHighlighting.version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
JULIASYNTAXHIGHLIGHTING_BRANCH = main
JULIASYNTAXHIGHLIGHTING_SHA1 = eb8097c5f1dbfca80b5e6664af031ff1fe0904af
JULIASYNTAXHIGHLIGHTING_SHA1 = 2680c8bde1aa274f25d7a434c645f16b3a1ee731
JULIASYNTAXHIGHLIGHTING_GIT_URL := https://github.com/julialang/JuliaSyntaxHighlighting.jl.git
JULIASYNTAXHIGHLIGHTING_TAR_URL = https://github.com/api/repos/julialang/JuliaSyntaxHighlighting.jl/tarball/$1
16 changes: 9 additions & 7 deletions test/syntax.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,8 @@ add_method_to_glob_fn!()
@test_parseerror "function finally() end"

# PR #16170
@test Meta.lower(Main, Meta.parse("true(x) = x")) == Expr(:error, "invalid function name \"true\"")
@test Meta.lower(Main, Meta.parse("false(x) = x")) == Expr(:error, "invalid function name \"false\"")
@test Meta.lower(Main, Meta.parse("true(x) = x")) == Expr(:error, "\"true\" is not a valid function argument name")
@test Meta.lower(Main, Meta.parse("false(x) = x")) == Expr(:error, "\"false\" is not a valid function argument name")

# issue #16355
@test Meta.lower(Main, :(f(d:Int...) = nothing)) == Expr(:error, "\"d:Int\" is not a valid function argument name")
Expand Down Expand Up @@ -925,8 +925,8 @@ g21054(>:) = >:2
@test g21054(-) == -2

# issue #21168
@test Meta.lower(Main, :(a.[1])) == Expr(:error, "invalid syntax \"a.[1]\"")
@test Meta.lower(Main, :(a.{1})) == Expr(:error, "invalid syntax \"a.{1}\"")
@test_broken Meta.lower(Main, :(a.[1])) == Expr(:error, "invalid syntax \"a.[1]\"")
@test_broken Meta.lower(Main, :(a.{1})) == Expr(:error, "invalid syntax \"a.{1}\"")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a regression

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe good with an issue at JuliaSyntax.jl so there is something tracking this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JuliaLang/JuliaSyntax.jl#532


# Issue #21225
let abstr = Meta.parse("abstract type X end")
Expand Down Expand Up @@ -1496,8 +1496,8 @@ end

# issue #26739
let exc = try Core.eval(@__MODULE__, :(sin.[1])) catch exc ; exc end
@test exc isa ErrorException
@test startswith(exc.msg, "syntax: invalid syntax \"sin.[1]\"")
@test_broken exc isa ErrorException
@test_broken startswith(exc.msg, "syntax: invalid syntax \"sin.[1]\"")
end

# issue #26873
Expand Down Expand Up @@ -2454,7 +2454,9 @@ end
@test_throws MethodError @m37134()(1.0) == 62

macro n37134()
:($(esc(Expr(:tuple, Expr(:..., :x))))->$(esc(:x)))
quote
((x...,)) -> (x)
end |> esc
end
@test @n37134()(2,1) === (2,1)

Expand Down
Loading