some updates for trimming #57531
Merged
some updates for trimming #57531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JeffBezanson
commented
Feb 25, 2025
JeffBezanson
commented
- add a nospecialize to throw_boundserror
- disable load path setup
- remove upstreamed change to utf8proc_map
- fix warning for accessing mod.main in the wrong world
- remove binding backedges when trimming
vtjnash
approved these changes
Feb 25, 2025
topolarity
reviewed
Feb 26, 2025
nsajko
added
the
trimming
- disable load path setup - remove upstreamed change to utf8proc_map - fix warning for accessing mod.main in the wrong world - remove binding backedges when trimming
JeffBezanson
force-pushed
the
jb/trimmingmisc2
branch
from
410b5e2 to
cff290c
Compare
topolarity
reviewed
Feb 28, 2025
Comment on lines
+36
to
+38
| init_depot_path() = nothing | ||
| init_load_path() = nothing | ||
| init_active_project() = nothing |
There was a problem hiding this comment.
We depend on these at runtime, esp. the depot path to lookup artifacts - I think this should likely be reverted too
topolarity
reviewed
Feb 28, 2025
| return String(resize!(buffer, nbytes)) | ||
| end | ||
| @eval Base.Sys begin | ||
| __init_build() = nothing |
There was a problem hiding this comment.
Similarly here - this code is responsible for setting up Sys.BINDIR and Sys.STDLIB
Not sure we should just be leaving them uninitialized
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2025
- disable load path setup - remove upstreamed change to utf8proc_map - fix warning for accessing mod.main in the wrong world - remove binding backedges when trimming (cherry picked from commit d77c24f)
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.