-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
typeintersect: fix triangular vars handling outside constructor. #58018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
skip intersection/subtyping under circular env.
@nanosoldier |
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed6 packages crashed on the previous version too. ✖ Packages that failed14 packages failed only on the current version.
1380 packages failed on the previous version too. ✔ Packages that passed tests29 packages passed tests only on the current version.
5246 packages passed tests on the previous version too. ~ Packages that at least loaded8 packages successfully loaded only on the current version.
2858 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether1 packages were skipped only on the current version.
912 packages were skipped on the previous version too. |
@nanosoldier |
The package evaluation job you requested has completed - no new issues were detected. Report summary✖ Packages that failed3 packages failed on the previous version too. ✔ Packages that passed tests8 packages passed tests on the previous version too. ~ Packages that at least loaded3 packages successfully loaded on the previous version too. |
Fix #57852.
The 'e->triangle' branch doesn't make sense for variables outside the constructor.
Let pkgeval tell us if
constraintkind
based branches are suitable for handling them.(The second commit is needed to fix some stack overflow regression.)