Skip to content

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Apr 6, 2025

Fix #57852.
The 'e->triangle' branch doesn't make sense for variables outside the constructor.
Let pkgeval tell us if constraintkind based branches are suitable for handling them.
(The second commit is needed to fix some stack overflow regression.)

@N5N3 N5N3 added types and dispatch Types, subtyping and method dispatch needs pkgeval Tests for all registered packages should be run with this change backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 labels Apr 6, 2025
@N5N3
Copy link
Member Author

N5N3 commented Apr 6, 2025

@nanosoldier runtests()

@N5N3 N5N3 requested a review from vtjnash April 6, 2025 09:21
@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

❗ Packages that crashed

6 packages crashed on the previous version too.

✖ Packages that failed

14 packages failed only on the current version.

  • Package has test failures: 1 packages
  • Package tests unexpectedly errored: 1 packages
  • Tests became inactive: 2 packages
  • Test duration exceeded the time limit: 10 packages

1380 packages failed on the previous version too.

✔ Packages that passed tests

29 packages passed tests only on the current version.

  • Other: 29 packages

5246 packages passed tests on the previous version too.

~ Packages that at least loaded

8 packages successfully loaded only on the current version.

  • Other: 8 packages

2858 packages successfully loaded on the previous version too.

➖ Packages that were skipped altogether

1 packages were skipped only on the current version.

  • Package could not be installed: 1 packages

912 packages were skipped on the previous version too.

@N5N3
Copy link
Member Author

N5N3 commented Apr 7, 2025

@nanosoldier runtests(["MLJTSVDInterface", "CharacteristicInvFourier", "ParameterizedQuantumControl", "AstroForceModels", "SDDP", "DECAES", "PsychomotorVigilanceTask", "ReducedBasis", "DifferentiableBackwardEuler", "VLBIPlots", "ReactionDiffusion", "EarthSciData", "StratIntervals", "BloqadeGates"])

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - no new issues were detected.
The full report is available.

Report summary

✖ Packages that failed

3 packages failed on the previous version too.

✔ Packages that passed tests

8 packages passed tests on the previous version too.

~ Packages that at least loaded

3 packages successfully loaded on the previous version too.

@N5N3 N5N3 removed the needs pkgeval Tests for all registered packages should be run with this change label Apr 8, 2025
@N5N3 N5N3 merged commit ec424d4 into JuliaLang:master Apr 8, 2025
7 of 14 checks passed
@N5N3 N5N3 deleted the intersect-fix branch April 8, 2025 06:33
KristofferC pushed a commit that referenced this pull request Apr 9, 2025
)

Fix #57852.
The 'e->triangle' branch doesn't make sense for variables outside the
constructor.
Let pkgeval tell us if `constraintkind` based branches are suitable for
handling them.
(The second commit is needed to fix some stack overflow regression.)

(cherry picked from commit ec424d4)
@KristofferC KristofferC mentioned this pull request Apr 9, 2025
51 tasks
N5N3 added a commit that referenced this pull request Apr 9, 2025
N5N3 added a commit that referenced this pull request Apr 9, 2025
This was referenced Apr 9, 2025
@N5N3 N5N3 removed backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 labels Apr 9, 2025
KristofferC pushed a commit that referenced this pull request Jun 5, 2025
KristofferC pushed a commit that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SumOfSquares error in inference
3 participants