Skip to content

Conversation

Keno
Copy link
Member

@Keno Keno commented Apr 11, 2025

Restores dropping these after #57979

@Keno Keno merged commit bd193e4 into master Apr 12, 2025
5 of 7 checks passed
@Keno Keno deleted the kf/dropconstabilocalsrcs branch April 12, 2025 02:01
vtjnash added a commit that referenced this pull request Apr 21, 2025
vtjnash added a commit that referenced this pull request Apr 22, 2025
The point of #57979 was to make inference faster, but it made it instead
much slower
(83524ac#commitcomment-155658124),
so revert back to the fast behavior before it was "optimized" (and
revert the bugfixes for the original commit).
Keno added a commit that referenced this pull request Apr 23, 2025
Keno added a commit that referenced this pull request Apr 30, 2025
Reverts #58182. The API changes were intentional and
desirable. Let's figure out why nansoldier was upset and re-apply this.

---------

Co-authored-by: Cédric Belmant <[email protected]>
serenity4 pushed a commit to serenity4/julia that referenced this pull request May 1, 2025
serenity4 pushed a commit to serenity4/julia that referenced this pull request May 1, 2025
JuliaLang#58182)

The point of JuliaLang#57979 was to make inference faster, but it made it instead
much slower
(JuliaLang@83524ac#commitcomment-155658124),
so revert back to the fast behavior before it was "optimized" (and
revert the bugfixes for the original commit).
serenity4 added a commit to serenity4/julia that referenced this pull request May 1, 2025
JuliaLang#58203)

Reverts JuliaLang#58182. The API changes were intentional and
desirable. Let's figure out why nansoldier was upset and re-apply this.

---------

Co-authored-by: Cédric Belmant <[email protected]>
LebedevRI pushed a commit to LebedevRI/julia that referenced this pull request May 2, 2025
JuliaLang#58182)

The point of JuliaLang#57979 was to make inference faster, but it made it instead
much slower
(JuliaLang@83524ac#commitcomment-155658124),
so revert back to the fast behavior before it was "optimized" (and
revert the bugfixes for the original commit).
charleskawczynski pushed a commit to charleskawczynski/julia that referenced this pull request May 12, 2025
JuliaLang#58203)

Reverts JuliaLang#58182. The API changes were intentional and
desirable. Let's figure out why nansoldier was upset and re-apply this.

---------

Co-authored-by: Cédric Belmant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant